fix: Don't warn about missing view on PerformanceMetric events#2454
Merged
fuzzybinary merged 1 commit intoDec 16, 2024
Merged
Conversation
PerformanceMetric events are triggered automatically by some of the cross platform frameworks, and can result in log spam as views transition or if no view is active. Fix it so that the performance metric event is considered a silent orphaned event type. refs: RUM-6138
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2454 +/- ##
===========================================
+ Coverage 70.27% 70.31% +0.03%
===========================================
Files 780 780
Lines 28823 28822 -1
Branches 4824 4824
===========================================
+ Hits 20255 20264 +9
+ Misses 7226 7220 -6
+ Partials 1342 1338 -4
|
0xnm
reviewed
Dec 16, 2024
0xnm
left a comment
Member
There was a problem hiding this comment.
What is the case when it is sent while there is no active view?
xgouchet
approved these changes
Dec 16, 2024
Member
Author
There are a few:
|
fuzzybinary
deleted the
jward/RUM-6138-silence-performance-metric-spam
branch
December 16, 2024 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PerformanceMetric events are triggered automatically by some of the cross platform frameworks, and can result in log spam as views transition or if no view is active. Fix it so that the performance metric event is considered a silent orphaned event type.
refs: RUM-6138
Review checklist (to be filled by reviewers)