Skip to content

RUM-7195: Support interop view from Compose#2452

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/ensure-webview
Dec 12, 2024
Merged

RUM-7195: Support interop view from Compose#2452
ambushwork merged 1 commit into
developfrom
yl/compose/ensure-webview

Conversation

@ambushwork

@ambushwork ambushwork commented Dec 11, 2024

Copy link
Copy Markdown
Member

What does this PR do?

A callback InteropViewCallback is added inside mappingContext so that in semantics tree, whenever an interop view is seen in the semantics node, this callback can be called to map in the way of how we are doing in the TreeViewTraversal.

with this PR, AndroidView can be seen in Session Replay, WebView embedded with AndroidView can be seen as well.

Motivation

RUM-7195

Dem

ezgif-4-b418e69d8b
o

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/compose/ensure-webview branch from 607d741 to 542f8fe Compare December 11, 2024 16:29
@ambushwork
ambushwork marked this pull request as ready for review December 11, 2024 16:51
@ambushwork
ambushwork requested review from a team as code owners December 11, 2024 16:51
@ambushwork
ambushwork force-pushed the yl/compose/ensure-webview branch from 542f8fe to a81922a Compare December 11, 2024 16:51
0xnm
0xnm approved these changes Dec 12, 2024
View reviewed changes
Comment thread ...ion-replay/src/main/kotlin/com/datadog/android/sessionreplay/recorder/InteropViewCallback.kt
@ambushwork
ambushwork force-pushed the yl/compose/ensure-webview branch from a81922a to c8d3254 Compare December 12, 2024 08:49
@codecov-commenter

codecov-commenter commented Dec 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (8504c86) to head (c8d3254).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...al/recorder/callback/DefaultInteropViewCallback.kt 37.50% 5 Missing ⚠️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 77.78% 2 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 1 Missing ⚠️
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 1 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2452      +/-   ##
===========================================
+ Coverage    70.28%   70.34%   +0.06%     
===========================================
  Files          779      780       +1     
  Lines        28801    28822      +21     
  Branches      4821     4824       +3     
===========================================
+ Hits         20241    20273      +32     
+ Misses        7213     7202      -11     
  Partials      1347     1347
Files with missing lines Coverage Δ
...rnal/mappers/semantics/AndroidComposeViewMapper.kt 92.31% <ø> (ø)
...se/internal/mappers/semantics/ComposeViewMapper.kt 81.25% <ø> (ø)
...essionreplay/internal/recorder/SnapshotProducer.kt 95.83% <100.00%> (+0.18%) ⬆️
...g/android/sessionreplay/recorder/MappingContext.kt 100.00% <100.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 2.08% <0.00%> (-0.04%) ⬇️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 75.81% <0.00%> (-0.62%) ⬇️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 75.00% <77.78%> (+1.03%) ⬆️
...al/recorder/callback/DefaultInteropViewCallback.kt 37.50% <37.50%> (ø)

... and 28 files with indirect coverage changes

@ambushwork
ambushwork merged commit 551b859 into develop Dec 12, 2024
@ambushwork
ambushwork deleted the yl/compose/ensure-webview branch December 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @jonathanmos