Skip to content

[RUM-7018] React Native Session Replay support#2448

Merged
marco-saia-datadog merged 1 commit into
developfrom
marcosaia/RUM-7018/react-native-support
Dec 17, 2024
Merged

[RUM-7018] React Native Session Replay support#2448
marco-saia-datadog merged 1 commit into
developfrom
marcosaia/RUM-7018/react-native-support

Conversation

@marco-saia-datadog

@marco-saia-datadog marco-saia-datadog commented Dec 10, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Exposes some classes and apply some changes to the codebase in order to grant support to React Native Session Replay capabilities.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Dec 10, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (551b859) to head (a12c7ad).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...m/datadog/android/internal/utils/ImageViewUtils.kt 0.00% 7 Missing ⚠️
...d/sessionreplay/recorder/mapper/ImageViewMapper.kt 57.14% 3 Missing ⚠️
...sessionreplay/internal/recorder/resources/Cache.kt 0.00% 2 Missing ⚠️
...internal/recorder/resources/BitmapCachesManager.kt 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2448      +/-   ##
===========================================
- Coverage    70.27%   70.00%   -0.27%     
===========================================
  Files          780      781       +1     
  Lines        28823    28851      +28     
  Branches      4824     4827       +3     
===========================================
- Hits         20255    20196      -59     
- Misses        7226     7325      +99     
+ Partials      1342     1330      -12
Files with missing lines Coverage Δ
.../java/com/datadog/android/internal/utils/IntExt.kt 0.00% <ø> (ø)
...java/com/datadog/android/internal/utils/LongExt.kt 0.00% <ø> (ø)
...ionreplay/material/internal/ChipWireframeMapper.kt 92.86% <100.00%> (+0.26%) ⬆️
.../sessionreplay/internal/DefaultRecorderProvider.kt 93.70% <100.00%> (+0.05%) ⬆️
...ssionreplay/internal/recorder/ViewUtilsInternal.kt 100.00% <ø> (ø)
...ternal/recorder/callback/RecorderWindowCallback.kt 91.95% <ø> (ø)
...eplay/internal/recorder/mapper/BasePickerMapper.kt 100.00% <ø> (ø)
...l/recorder/mapper/CheckableCompoundButtonMapper.kt 37.50% <ø> (ø)
...nternal/recorder/mapper/CheckableTextViewMapper.kt 63.79% <100.00%> (+5.90%) ⬆️
.../internal/recorder/mapper/CheckedTextViewMapper.kt 75.00% <ø> (ø)
... and 19 more

... and 26 files with indirect coverage changes

@marco-saia-datadog
marco-saia-datadog marked this pull request as ready for review December 11, 2024 09:39
@marco-saia-datadog
marco-saia-datadog requested review from a team as code owners December 11, 2024 09:39
0xnm
0xnm reviewed Dec 11, 2024
View reviewed changes
Comment thread ...ion-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/DrawableUtils.kt
Comment thread ...eplay/src/main/kotlin/com/datadog/android/sessionreplay/recorder/resources/DrawableCopier.kt
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
jonathanmos
jonathanmos approved these changes Dec 12, 2024
View reviewed changes
Comment thread dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/ImageViewUtils.kt Outdated
@marco-saia-datadog
marco-saia-datadog force-pushed the marcosaia/RUM-7018/react-native-support branch 4 times, most recently from 427dafe to 7a92c24 Compare December 12, 2024 14:28
0xnm
0xnm approved these changes Dec 16, 2024
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments/suggestions, but nothing blocking.

Comment thread dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/ImageViewUtils.kt Outdated
Comment thread .../kotlin/com/datadog/android/sessionreplay/internal/recorder/resources/BitmapCachesManager.kt
Comment thread ...d-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/RectExt.kt Outdated
Comment thread ...tlin/com/datadog/android/sessionreplay/recorder/mapper/BaseAsyncBackgroundWireframeMapper.kt Outdated
Comment thread ...tlin/com/datadog/android/sessionreplay/recorder/mapper/BaseAsyncBackgroundWireframeMapper.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
Comment thread ...datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt Outdated
@marco-saia-datadog
marco-saia-datadog force-pushed the marcosaia/RUM-7018/react-native-support branch 4 times, most recently from 320760f to 7f56e9a Compare December 16, 2024 16:56
@marco-saia-datadog
marco-saia-datadog force-pushed the marcosaia/RUM-7018/react-native-support branch from 7f56e9a to a12c7ad Compare December 17, 2024 08:47
@marco-saia-datadog
marco-saia-datadog merged commit 9f3d758 into develop Dec 17, 2024
@marco-saia-datadog
marco-saia-datadog deleted the marcosaia/RUM-7018/react-native-support branch December 17, 2024 10:51
This was referenced Dec 17, 2024
Closed
Closed
@0xnm 0xnm mentioned this pull request Dec 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-saia-datadog @codecov-commenter @0xnm @jonathanmos