RUM-7624 Add integration tests for ITNV metric#2445
Merged
mariusc83 merged 1 commit intoDec 11, 2024
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-7624/add-integration-tests-for-itnv-metric
branch
from
December 10, 2024 13:12
45bd1c9 to
e64740a
Compare
mariusc83
force-pushed
the
mconstantin/rum-7624/add-integration-tests-for-itnv-metric
branch
from
December 10, 2024 13:14
e64740a to
3fc581f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2445 +/- ##
==============================================================
+ Coverage 70.04% 70.10% +0.06%
==============================================================
Files 775 775
Lines 28736 28736
Branches 4812 4812
==============================================================
+ Hits 20126 20144 +18
+ Misses 7278 7269 -9
+ Partials 1332 1323 -9
|
mariusc83
marked this pull request as ready for review
December 10, 2024 14:10
xgouchet
approved these changes
Dec 11, 2024
ambushwork
approved these changes
Dec 11, 2024
| } | ||
| } | ||
|
|
||
| @RepeatedTest(10) |
Member
There was a problem hiding this comment.
I think we should remove @RepeatedTest when pushing to remote
Member
Author
There was a problem hiding this comment.
We have them everywhere in all the tests just to make sure we have enough test iterations there. They are super fast.
| } | ||
| } | ||
|
|
||
| @RepeatedTest(10) |
| } | ||
| } | ||
|
|
||
| @RepeatedTest(10) |
| } | ||
| } | ||
|
|
||
| @RepeatedTest(10) |
| } | ||
| } | ||
|
|
||
| @RepeatedTest(2) |
| } | ||
| } | ||
|
|
||
| @RepeatedTest(2) |
mariusc83
deleted the
mconstantin/rum-7624/add-integration-tests-for-itnv-metric
branch
December 11, 2024 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)