RUM-7643 Correctly handle TTNS when resource was stopped with error#2444
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-7643/fix-ttns-computation-when-resource-stopped-with-error
branch
from
December 10, 2024 09:27
b3b77fb to
7efc6d9
Compare
mariusc83
marked this pull request as ready for review
December 10, 2024 09:42
xgouchet
approved these changes
Dec 10, 2024
mariusc83
deleted the
mconstantin/rum-7643/fix-ttns-computation-when-resource-stopped-with-error
branch
December 10, 2024 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently if a resource was stopped with an error we are computing the TTNS metric no matter if the error event was persisted or not. To align with the the approach we took for the normal resource stop we will have to make sure that the TTNS metric will only be computed when the error event was persisted.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)