Skip to content

RUM-7623 Add integration tests for TTNS metric#2442

Merged
mariusc83 merged 1 commit into
feature/view-loading-timesfrom
mconstantin/rum-7623/add-integration-tests-for-ttns-metric
Dec 10, 2024
Merged

RUM-7623 Add integration tests for TTNS metric#2442
mariusc83 merged 1 commit into
feature/view-loading-timesfrom
mconstantin/rum-7623/add-integration-tests-for-ttns-metric

Conversation

@mariusc83

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Dec 9, 2024
@codecov-commenter

codecov-commenter commented Dec 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (7efc6d9) to head (dda93a3).
Report is 3 commits behind head on feature/view-loading-times.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/view-loading-times    #2442      +/-   ##
==============================================================
+ Coverage                       70.09%   70.10%   +0.01%     
==============================================================
  Files                             775      775              
  Lines                           28736    28736              
  Branches                         4812     4812              
==============================================================
+ Hits                            20140    20143       +3     
- Misses                           7258     7262       +4     
+ Partials                         1338     1331       -7     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 94.62% <100.00%> (-0.51%) ⬇️

... and 30 files with indirect coverage changes

@mariusc83
mariusc83 force-pushed the mconstantin/rum-7623/add-integration-tests-for-ttns-metric branch 3 times, most recently from 73a1ea0 to 62ba83b Compare December 10, 2024 09:53
@mariusc83
mariusc83 marked this pull request as ready for review December 10, 2024 09:54
@mariusc83
mariusc83 requested review from a team as code owners December 10, 2024 09:54
@mariusc83
mariusc83 changed the base branch from feature/view-loading-times to mconstantin/rum-7643/fix-ttns-computation-when-resource-stopped-with-error December 10, 2024 09:54
@mariusc83
mariusc83 force-pushed the mconstantin/rum-7623/add-integration-tests-for-ttns-metric branch from 62ba83b to dda93a3 Compare December 10, 2024 10:23
xgouchet
xgouchet previously approved these changes Dec 10, 2024
Base automatically changed from mconstantin/rum-7643/fix-ttns-computation-when-resource-stopped-with-error to feature/view-loading-times December 10, 2024 10:33
@mariusc83
mariusc83 dismissed xgouchet’s stale review December 10, 2024 10:33

The base branch was changed.

@mariusc83
mariusc83 requested a review from xgouchet December 10, 2024 10:33
@mariusc83
mariusc83 merged commit 6658b89 into feature/view-loading-times Dec 10, 2024
@mariusc83
mariusc83 deleted the mconstantin/rum-7623/add-integration-tests-for-ttns-metric branch December 10, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants