RUM-7590 Correct the way we register the initial resources for TTNS metric#2439
Merged
mariusc83 merged 1 commit intoDec 9, 2024
Conversation
mariusc83
force-pushed
the
mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource
branch
2 times, most recently
from
December 6, 2024 10:49
82b5b95 to
df03c5e
Compare
Base automatically changed from
mconstantin/fix-the-way-we-record-last-interaction
to
feature/view-loading-times
December 6, 2024 10:49
mariusc83
force-pushed
the
mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource
branch
from
December 6, 2024 10:53
df03c5e to
bc9ab22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2439 +/- ##
==============================================================
- Coverage 70.07% 70.03% -0.04%
==============================================================
Files 775 775
Lines 28708 28722 +14
Branches 4809 4810 +1
==============================================================
- Hits 20116 20113 -3
- Misses 7273 7280 +7
- Partials 1319 1329 +10
|
mariusc83
marked this pull request as ready for review
December 6, 2024 11:49
ambushwork
previously approved these changes
Dec 9, 2024
mariusc83
force-pushed
the
mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource
branch
from
December 9, 2024 10:31
bc9ab22 to
aa63ccf
Compare
mariusc83
force-pushed
the
mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource
branch
from
December 9, 2024 10:43
aa63ccf to
199dec9
Compare
ambushwork
approved these changes
Dec 9, 2024
mariusc83
deleted the
mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource
branch
December 9, 2024 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to fix the way we are recording the initial resources needed for the TTNS metric computation by only doing this in the onSuccess callbacks once the resource event was persisted for upload. There are 2 special cases where the resource is stopped due to errors and these are treated separately.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)