RUM-7527: Deprecate Datadog GlobalTracer class#2438
Conversation
0xnm
left a comment
There was a problem hiding this comment.
I'm not sure we can remove it, because even though it is not used for the means of the Android SDK, some users may rely on this as an exported symbol for their usage with com.datadog.trace.api.Tracer (this would be strange though).
Maybe it is better to deprecate it instead?
I really want to avoid the confusion here, I would say removing is better as there should not be any usage of the |
|
Yes, for sure, its usage is a misuse, but at the same time it is binary-incompatible change and we can do it only for the next major release for the public-facing API (we cannot say that there is no anyone using this symbol for some strange needs). At the same time But anyway, it is your call. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2438 +/- ##
===========================================
+ Coverage 70.06% 70.10% +0.04%
===========================================
Files 769 769
Lines 28511 28509 -2
Branches 4778 4778
===========================================
+ Hits 19976 19986 +10
+ Misses 7190 7185 -5
+ Partials 1345 1338 -7
|
|
I would tend to agree with @0xnm here: removing it might break using for some of our customers. |
e7742db to
98c6002
Compare
98c6002 to
e18c280
Compare
What does this PR do?
Deprecate Datadog
GlobalTracerclass to avoid confusion with opentracingGlobalTracerMotivation
RUM-7527
Review checklist (to be filled by reviewers)