Skip to content

RUM-6454: fixing potential issues with subdomain host lookup#2436

Merged
satween merged 1 commit into
developfrom
tvaleev/rum-6454/lookup-logic-improvements
Dec 5, 2024
Merged

RUM-6454: fixing potential issues with subdomain host lookup#2436
satween merged 1 commit into
developfrom
tvaleev/rum-6454/lookup-logic-improvements

Conversation

@satween

@satween satween commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Changing logic with subdomain lookups. Now algorithm follows next logic :

  • first search the exact match
  • if not found, check match for subdomain pattern
  • if not found search for the * entry

Motivation

This change puts matching logic into valid order: from strict to lenient one

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween force-pushed the tvaleev/rum-6454/lookup-logic-improvements branch 2 times, most recently from 8715a13 to e2b5426 Compare December 5, 2024 17:18
@satween
satween force-pushed the tvaleev/rum-6454/lookup-logic-improvements branch from e2b5426 to 2a36396 Compare December 5, 2024 18:07
@codecov-commenter

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (db3e1d6) to head (2a36396).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...nal/net/DefaultFirstPartyHostHeaderTypeResolver.kt 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2436      +/-   ##
===========================================
+ Coverage    70.12%   70.14%   +0.01%     
===========================================
  Files          769      769              
  Lines        28510    28510              
  Branches      4777     4778       +1     
===========================================
+ Hits         19992    19996       +4     
+ Misses        7185     7178       -7     
- Partials      1333     1336       +3
Files with missing lines Coverage Δ
...nal/net/DefaultFirstPartyHostHeaderTypeResolver.kt 77.27% <0.00%> (-13.20%) ⬇️

... and 29 files with indirect coverage changes

@satween
satween marked this pull request as ready for review December 5, 2024 19:25
@satween
satween requested review from a team as code owners December 5, 2024 19:25
@satween
satween merged commit 661033b into develop Dec 5, 2024
@satween
satween deleted the tvaleev/rum-6454/lookup-logic-improvements branch December 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satween @codecov-commenter @0xnm