Skip to content

RUM-7567: Apply hide view override on semantics node#2434

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/hide-override
Dec 9, 2024
Merged

RUM-7567: Apply hide view override on semantics node#2434
ambushwork merged 1 commit into
developfrom
yl/compose/hide-override

Conversation

@ambushwork

@ambushwork ambushwork commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Show hide placeholder wireframe when user calls .sessionReplayHide(hide = true) on the composable modifier.

Motivation

RUM-7567

Demo

A demo about how it looks like:
image

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (1f84948) to head (6439e4d).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 80.00% 1 Missing and 1 partial ⚠️
...tadog/android/sessionreplay/compose/ModifierExt.kt 0.00% 1 Missing ⚠️
.../internal/mappers/semantics/ComposeHiddenMapper.kt 93.33% 1 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2434      +/-   ##
===========================================
- Coverage    70.14%   70.13%   -0.01%     
===========================================
  Files          769      770       +1     
  Lines        28508    28535      +27     
  Branches      4777     4780       +3     
===========================================
+ Hits         19996    20012      +16     
- Misses        7176     7191      +15     
+ Partials      1336     1332       -4
Files with missing lines Coverage Δ
...tadog/android/sessionreplay/compose/ModifierExt.kt 0.00% <0.00%> (ø)
.../internal/mappers/semantics/ComposeHiddenMapper.kt 93.33% <93.33%> (ø)
...ionreplay/compose/internal/utils/SemanticsUtils.kt 75.00% <0.00%> (-0.63%) ⬇️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 73.97% <80.00%> (+0.96%) ⬆️

... and 31 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review December 9, 2024 10:26
@ambushwork
ambushwork requested review from a team as code owners December 9, 2024 10:26
0xnm
0xnm approved these changes Dec 9, 2024
View reviewed changes
Comment thread ...adog/android/sessionreplay/compose/internal/mappers/semantics/ComposeHiddenNodeMapperTest.kt
@ambushwork
ambushwork merged commit a8ff9aa into develop Dec 9, 2024
@ambushwork
ambushwork deleted the yl/compose/hide-override branch December 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @mariusc83 @0xnm