Skip to content

RUM-6535: Add backwards compatibility for Coil AsyncImage#2432

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/fix-image-regression
Dec 5, 2024
Merged

RUM-6535: Add backwards compatibility for Coil AsyncImage#2432
ambushwork merged 1 commit into
developfrom
yl/compose/fix-image-regression

Conversation

@ambushwork

@ambushwork ambushwork commented Dec 5, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Coil has done a migration on the painter class in this PR, which causes our reflection not able to retrieve the bitmap painter, This PR is to add the support before the migration.

Motivation

RUM-6535

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/compose/fix-image-regression branch from c7aa1b7 to 1f84948 Compare December 5, 2024 13:55
@codecov-commenter

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (4f55776) to head (1f84948).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 7 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2432      +/-   ##
===========================================
+ Coverage    70.12%   70.14%   +0.03%     
===========================================
  Files          769      769              
  Lines        28504    28508       +4     
  Branches      4774     4777       +3     
===========================================
+ Hits         19986    19996      +10     
+ Misses        7183     7176       -7     
- Partials      1335     1336       +1
Files with missing lines Coverage Δ
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 2.44% <0.00%> (-0.06%) ⬇️

... and 36 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review December 5, 2024 14:21
@ambushwork
ambushwork requested review from a team as code owners December 5, 2024 14:21
@ambushwork
ambushwork merged commit 53e3a46 into develop Dec 5, 2024
@ambushwork
ambushwork deleted the yl/compose/fix-image-regression branch December 5, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @jonathanmos