Fix the way we are recording the last interaction for ITNV metric#2431
Merged
mariusc83 merged 1 commit intoDec 6, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2431 +/- ##
==============================================================
- Coverage 70.04% 70.03% -0.00%
==============================================================
Files 775 775
Lines 28694 28708 +14
Branches 4809 4809
==============================================================
+ Hits 20096 20105 +9
Misses 7276 7276
- Partials 1322 1327 +5
|
mariusc83
force-pushed
the
mconstantin/fix-the-way-we-record-last-interaction
branch
from
December 5, 2024 12:32
cbdf023 to
581338c
Compare
mariusc83
marked this pull request as ready for review
December 5, 2024 12:54
mariusc83
force-pushed
the
mconstantin/fix-the-way-we-record-last-interaction
branch
from
December 5, 2024 13:15
581338c to
3a49cd0
Compare
ambushwork
approved these changes
Dec 5, 2024
mariusc83
deleted the
mconstantin/fix-the-way-we-record-last-interaction
branch
December 6, 2024 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The interval we consider for the interaction-to-next-view metric is the moment the last action finished on the previous view until the moment the new view was created. Based on the last discussion we decided to completely rely on the RUM ActionEvents that were sent as potential last interactions meaning that we had to do several changes in the
RumActionScopeby reporting more information in theActionSentevent to theRumViewScope.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)