RUM-7528 Introduce the setLastInteractionIdentifier Public API#2428
Merged
mariusc83 merged 2 commits intoDec 4, 2024
Conversation
mariusc83
force-pushed
the
mconstantin/rum-7528/add-public-api-for-itnv-identification
branch
from
December 3, 2024 11:44
31b857c to
6c04bce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/view-loading-times #2428 +/- ##
==============================================================
+ Coverage 70.00% 70.11% +0.11%
==============================================================
Files 775 775
Lines 28676 28694 +18
Branches 4807 4809 +2
==============================================================
+ Hits 20072 20116 +44
+ Misses 7278 7251 -27
- Partials 1326 1327 +1
|
mariusc83
force-pushed
the
mconstantin/rum-7528/add-public-api-for-itnv-identification
branch
from
December 3, 2024 12:51
6c04bce to
e8122d9
Compare
mariusc83
marked this pull request as ready for review
December 3, 2024 13:11
xgouchet
previously approved these changes
Dec 3, 2024
|
|
||
| /** | ||
| * Sets the identifier strategy for initial network resources used to compute the time to network settled | ||
| * Sets a custom identifier for initial network resources used to compute the time to network settled |
Contributor
There was a problem hiding this comment.
Note
Nitpick: this should belong in the previous PR
mariusc83
force-pushed
the
mconstantin/rum-7174/add-timing-strategy-for-ttns-requests-identification
branch
from
December 4, 2024 09:15
85893e3 to
48ab0a2
Compare
Base automatically changed from
mconstantin/rum-7174/add-timing-strategy-for-ttns-requests-identification
to
feature/view-loading-times
December 4, 2024 12:55
mariusc83
force-pushed
the
mconstantin/rum-7528/add-public-api-for-itnv-identification
branch
from
December 4, 2024 13:48
e8122d9 to
5a2c9be
Compare
xgouchet
approved these changes
Dec 4, 2024
mariusc83
deleted the
mconstantin/rum-7528/add-public-api-for-itnv-identification
branch
December 4, 2024 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following the RFC we are introducing the
setLastInteractionIdentifierAPI as part of theRumConfiguration#Builderin order to provide external control on which action intercepted on the previous view will be considered as the last interaction leading to the next view needed in theinteraction-to-next-viewmetric computation. The default identifier being used is aTimeBasedInteractionIdentifierwith a default threshold interval of 3000ms. More about this you can read in the class docs in the PR itself. This could be re - used by our users in the Configuration Builder by changing the time interval to their internal needs.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)