Skip to content

RUM-7489 Handle readOnly additionalProperties#2423

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-7489/json_readonly_additional_properties
Dec 2, 2024
Merged

RUM-7489 Handle readOnly additionalProperties#2423
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-7489/json_readonly_additional_properties

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Make sure that the readOnly setting on additional properties is taken into account when converting Json Schema into a Kotlin data class.

@xgouchet
xgouchet requested review from a team as code owners November 29, 2024 19:36
@codecov-commenter

codecov-commenter commented Nov 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (4923861) to head (8d6434a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2423      +/-   ##
===========================================
+ Coverage    70.13%   70.17%   +0.04%     
===========================================
  Files          769      769              
  Lines        28530    28530              
  Branches      4782     4782              
===========================================
+ Hits         20007    20019      +12     
+ Misses        7179     7169      -10     
+ Partials      1344     1342       -2     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 94.50% <ø> (ø)

... and 32 files with indirect coverage changes

Comment thread features/dd-sdk-android-rum/api/apiSurface
@xgouchet
xgouchet merged commit ba86ac8 into develop Dec 2, 2024
@xgouchet
xgouchet deleted the xgouchet/RUM-7489/json_readonly_additional_properties branch December 2, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants