Skip to content

RUM-7070: supporting is_main_process property in telemetry configuration#2422

Merged
satween merged 1 commit into
developfrom
tvaleev/rum-7070/is_main_process-property-support
Dec 2, 2024
Merged

RUM-7070: supporting is_main_process property in telemetry configuration#2422
satween merged 1 commit into
developfrom
tvaleev/rum-7070/is_main_process-property-support

Conversation

@satween

@satween satween commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Adding isMainProcess property into telemetry configuration

Motivation

We are trying to understand how are our customers using the SDK and if they are tracking their applications in the main process only

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween force-pushed the tvaleev/rum-7070/is_main_process-property-support branch from fe72096 to 1d7b332 Compare November 29, 2024 17:53
@codecov-commenter

codecov-commenter commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (ba86ac8) to head (c488ebc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2422   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files          769      769           
  Lines        28530    28489   -41     
  Branches      4782     4773    -9     
========================================
- Hits         20007    19979   -28     
+ Misses        7180     7169   -11     
+ Partials      1343     1341    -2     
Files with missing lines Coverage Δ
...ndroid/telemetry/internal/TelemetryEventHandler.kt 87.21% <100.00%> (-2.02%) ⬇️

... and 29 files with indirect coverage changes

@satween
satween force-pushed the tvaleev/rum-7070/is_main_process-property-support branch from 1d7b332 to c488ebc Compare December 2, 2024 12:33
@satween
satween marked this pull request as ready for review December 2, 2024 13:33
@satween
satween requested review from a team as code owners December 2, 2024 13:33
@satween
satween merged commit b0b5766 into develop Dec 2, 2024
@satween
satween deleted the tvaleev/rum-7070/is_main_process-property-support branch December 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants