Skip to content

RUM-7476: Apply touch privacy override in RootSemanticsMapper#2421

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/touch-privacy
Dec 4, 2024
Merged

RUM-7476: Apply touch privacy override in RootSemanticsMapper#2421
ambushwork merged 1 commit into
developfrom
yl/compose/touch-privacy

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Apply touch privacy override in RootSemanticsMapper
  • Move TouchPrivacyManger into MappingContext so that RootSemanticsMapper can have access

Motivation

RUM-7476

Demo

ezgif-5-d1a1f1cc6c

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/compose/touch-privacy branch from 9b2cb34 to bbf70b3 Compare November 29, 2024 10:11
@codecov-commenter

codecov-commenter commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (4923861) to head (74b31c8).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 30.77% 8 Missing and 1 partial ⚠️
...ssionreplay/internal/recorder/TreeViewTraversal.kt 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2421      +/-   ##
===========================================
+ Coverage    70.13%   70.19%   +0.06%     
===========================================
  Files          769      769              
  Lines        28530    28544      +14     
  Branches      4782     4783       +1     
===========================================
+ Hits         20007    20034      +27     
+ Misses        7179     7174       -5     
+ Partials      1344     1336       -8
Files with missing lines Coverage Δ
...roid/sessionreplay/internal/TouchPrivacyManager.kt 94.74% <100.00%> (ø)
...nreplay/internal/recorder/SessionReplayRecorder.kt 97.08% <100.00%> (ø)
...essionreplay/internal/recorder/SnapshotProducer.kt 95.65% <100.00%> (+0.13%) ⬆️
...g/android/sessionreplay/recorder/MappingContext.kt 100.00% <100.00%> (ø)
...ssionreplay/internal/recorder/TreeViewTraversal.kt 67.95% <66.67%> (-0.41%) ⬇️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 73.02% <30.77%> (-9.34%) ⬇️

... and 30 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review December 3, 2024 10:27
@ambushwork
ambushwork requested review from a team as code owners December 3, 2024 10:27
0xnm
0xnm approved these changes Dec 3, 2024
View reviewed changes
Comment thread ...-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/recorder/MappingContext.kt Outdated
Comment thread .../datadog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapper.kt Outdated
@ambushwork
ambushwork force-pushed the yl/compose/touch-privacy branch from bbf70b3 to 74b31c8 Compare December 3, 2024 11:03
@ambushwork
ambushwork merged commit 4f55776 into develop Dec 4, 2024
@ambushwork
ambushwork deleted the yl/compose/touch-privacy branch December 4, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambushwork @codecov-commenter @0xnm