Move ImageSemanticsMapper reflection functions into ReflectionUtils#2419
Merged
Conversation
mariusc83
reviewed
Nov 28, 2024
| return ComposeReflection.ClipShapeField?.getSafe(modifier) as? Shape | ||
| } | ||
|
|
||
| fun getBitmapInVectorPainter(vectorPainter: VectorPainter): Bitmap? { |
Member
There was a problem hiding this comment.
❔ question: Do you have tests for these functions that you moved here ?
Member
Author
There was a problem hiding this comment.
No, reflection functions are tricky to test, they heavily depend on runtime environment. That's why I move all the reflection functions into this single class, and we are able to mock it and ensure the other parts by unit test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2419 +/- ##
===========================================
+ Coverage 70.09% 70.20% +0.12%
===========================================
Files 768 769 +1
Lines 28529 28530 +1
Branches 4783 4782 -1
===========================================
+ Hits 19995 20029 +34
+ Misses 7194 7163 -31
+ Partials 1340 1338 -2
|
ambushwork
marked this pull request as ready for review
November 28, 2024 15:01
mariusc83
approved these changes
Nov 28, 2024
0xnm
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow up commit of this PR
Move ImageSemanticsMapper reflection functions into ReflectionUtils
Review checklist (to be filled by reviewers)