Skip to content

RUM-7341: Add Compose FGM override API#2416

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/fgm-api
Nov 28, 2024
Merged

RUM-7341: Add Compose FGM override API#2416
ambushwork merged 1 commit into
developfrom
yl/compose/fgm-api

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 27, 2024

Copy link
Copy Markdown
Member

What does this PR do?

  • Add Session Replay FGM override APIs for
    • ImagePrivacy
    • TextAndInputPrivacy
    • TouchPrivacy
  • Implement ImagePrivacy and TextAndInputPrivacy in the semantics mapper.

Motivation

RUM-7341

Additional Notes

Touch Privacy will be applied in following commit

Demo

In each grid, the title of the grid means the override privacy of the content:

Sampe App Global configuration is Mask all Global configuration is Mask none
Screenshot 2024-11-27 at 13 01 32 Screenshot 2024-11-27 at 10 48 17 Screenshot 2024-11-27 at 10 51 12

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 41.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (4590058) to head (f1f0c1a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...tadog/android/sessionreplay/compose/ModifierExt.kt 0.00% 22 Missing ⚠️
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 25.00% 3 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2416      +/-   ##
===========================================
- Coverage    70.12%   70.08%   -0.04%     
===========================================
  Files          767      768       +1     
  Lines        28490    28529      +39     
  Branches      4778     4783       +5     
===========================================
+ Hits         19977    19992      +15     
- Misses        7170     7194      +24     
  Partials      1343     1343
Files with missing lines Coverage Δ
.../mappers/semantics/ContainerSemanticsNodeMapper.kt 93.33% <100.00%> (+15.56%) ⬆️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 82.35% <100.00%> (ø)
.../mappers/semantics/TextFieldSemanticsNodeMapper.kt 84.62% <100.00%> (+0.94%) ⬆️
...ernal/mappers/semantics/TextSemanticsNodeMapper.kt 88.00% <100.00%> (+5.39%) ⬆️
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 3.23% <25.00%> (+1.53%) ⬆️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 78.64% <0.00%> (-2.36%) ⬇️
...tadog/android/sessionreplay/compose/ModifierExt.kt 0.00% <0.00%> (ø)

... and 35 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review November 27, 2024 13:24
@ambushwork
ambushwork requested review from a team as code owners November 27, 2024 13:24
jonathanmos
jonathanmos approved these changes Nov 28, 2024
View reviewed changes
Comment thread ...android/sessionreplay/compose/internal/mappers/semantics/ContainerSemanticsNodeMapperTest.kt Outdated
Comment thread ...android/sessionreplay/compose/internal/mappers/semantics/TextFieldSemanticsNodeMapperTest.kt Outdated
@ambushwork
ambushwork merged commit 223c03d into develop Nov 28, 2024
@ambushwork
ambushwork deleted the yl/compose/fgm-api branch November 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambushwork @codecov-commenter @xgouchet @mariusc83 @jonathanmos