Skip to content

RUM-7081: Decouple Compose reflection functions and report to Telemetry#2415

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/reflection-telemetry
Nov 26, 2024
Merged

RUM-7081: Decouple Compose reflection functions and report to Telemetry#2415
ambushwork merged 1 commit into
developfrom
yl/compose/reflection-telemetry

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Decouple Compose reflection functions from SemanticsUtils to ReflectionUtils.
  • Add Unit test to SemanticsUtils
  • Clean up ComposeReflection so they can have unified logs and report to Telemetry.

Motivation

RUM-7081

Demo

RUM Telemetry result:
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/compose/reflection-telemetry branch from 8666dae to c03be5c Compare November 26, 2024 10:45
@ambushwork
ambushwork force-pushed the yl/compose/reflection-telemetry branch from c03be5c to 485ff8c Compare November 26, 2024 11:14
@codecov-commenter

codecov-commenter commented Nov 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 39.72603% with 44 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (a67406e) to head (485ff8c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 4.76% 20 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 16 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 77.78% 0 Missing and 8 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2415      +/-   ##
===========================================
+ Coverage    70.01%   70.18%   +0.17%     
===========================================
  Files          766      767       +1     
  Lines        28492    28490       -2     
  Branches      4782     4778       -4     
===========================================
+ Hits         19948    19994      +46     
+ Misses        7250     7156      -94     
- Partials      1294     1340      +46
Files with missing lines Coverage Δ
...ionreplay/compose/internal/utils/SemanticsUtils.kt 81.00% <77.78%> (+80.00%) ⬆️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 4.76% <4.76%> (ø)

... and 30 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review November 26, 2024 14:28
@ambushwork
ambushwork requested review from a team as code owners November 26, 2024 14:28
@ambushwork
ambushwork merged commit 4590058 into develop Nov 26, 2024
@ambushwork
ambushwork deleted the yl/compose/reflection-telemetry branch November 26, 2024 17:00
@ambushwork ambushwork mentioned this pull request Nov 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @jonathanmos