Skip to content

RUM-7342: Apply Global privacy level to semantics node mapper#2413

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/global-fgm
Nov 22, 2024
Merged

RUM-7342: Apply Global privacy level to semantics node mapper#2413
ambushwork merged 1 commit into
developfrom
yl/compose/global-fgm

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 22, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Apply Global privacy level to semantics node mapper, there are following major changes:

  • Remove legacy privacy in UiContext, replace it by input privacy and image privacy
  • Text and TextField semantics node mapper applied with input privacy
  • Image semantics node mapper applied with image privacy

Besides, in sample app, material3 lib version is downgraded to align with compose bom version

Motivation

RUM-7342

Additional Notes

Selection screen Typography screen Input screen
MASK_ALL Screenshot 2024-11-22 at 09 33 05 Screenshot 2024-11-22 at 09 33 27 Screenshot 2024-11-22 at 09 34 02
MASK_ALL_INPUTS Screenshot 2024-11-22 at 09 36 49 Screenshot 2024-11-22 at 09 37 08 Screenshot 2024-11-22 at 09 40 08
MASK_SENSITIVE_INPUTS Screenshot 2024-11-22 at 09 42 11 Screenshot 2024-11-22 at 09 42 28 Screenshot 2024-11-22 at 09 42 50
MASK_ALL MASK_LARGE_ONLY MASK_NONE
Screenshot 2024-11-22 at 09 44 49 Screenshot 2024-11-22 at 14 09 48 Screenshot 2024-11-22 at 14 07 44

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.86%. Comparing base (ad11589) to head (116e0e1).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...essionreplay/compose/internal/utils/StringUtils.kt 55.00% 4 Missing and 5 partials ⚠️
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 0.00% 1 Missing ⚠️
.../mappers/semantics/TextFieldSemanticsNodeMapper.kt 50.00% 0 Missing and 1 partial ⚠️
...ernal/mappers/semantics/TextSemanticsNodeMapper.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2413      +/-   ##
===========================================
- Coverage    69.87%   69.86%   -0.01%     
===========================================
  Files          766      766              
  Lines        28483    28490       +7     
  Branches      4778     4782       +4     
===========================================
+ Hits         19900    19903       +3     
  Misses        7263     7263              
- Partials      1320     1324       +4
Files with missing lines Coverage Δ
...d/sessionreplay/compose/internal/data/UiContext.kt 100.00% <100.00%> (ø)
...rnal/mappers/semantics/AndroidComposeViewMapper.kt 92.31% <ø> (-1.03%) ⬇️
...se/internal/mappers/semantics/ComposeViewMapper.kt 81.25% <ø> (-2.08%) ⬇️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 82.35% <100.00%> (+0.35%) ⬆️
.../recorder/resources/DefaultImageWireframeHelper.kt 95.11% <100.00%> (-0.05%) ⬇️
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 1.69% <0.00%> (ø)
.../mappers/semantics/TextFieldSemanticsNodeMapper.kt 83.67% <50.00%> (-1.74%) ⬇️
...ernal/mappers/semantics/TextSemanticsNodeMapper.kt 82.61% <50.00%> (+0.79%) ⬆️
...essionreplay/compose/internal/utils/StringUtils.kt 52.38% <55.00%> (-14.29%) ⬇️

... and 23 files with indirect coverage changes

---- 🚨 Try these New Features:

@ambushwork
ambushwork marked this pull request as ready for review November 22, 2024 13:50
@ambushwork
ambushwork requested review from a team as code owners November 22, 2024 13:50
0xnm
0xnm approved these changes Nov 22, 2024
View reviewed changes
Comment thread ...pose/src/main/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/StringUtils.kt Outdated
Comment thread ...adog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapperTest.kt Outdated
Comment thread ...adog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapperTest.kt Outdated
Comment thread ...adog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapperTest.kt Outdated
Comment thread ...adog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapperTest.kt Outdated
@ambushwork
ambushwork force-pushed the yl/compose/global-fgm branch from 43896b6 to 116e0e1 Compare November 22, 2024 14:00
@ambushwork
ambushwork merged commit 9c591a9 into develop Nov 22, 2024
@ambushwork
ambushwork deleted the yl/compose/global-fgm branch November 22, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambushwork @codecov-commenter @0xnm