Improve the log message when exception happen during Upload#2411
Merged
Conversation
0xnm
approved these changes
Nov 21, 2024
|
|
||
| if (throwable != null) { | ||
| append(" (") | ||
| append(throwable.javaClass.name) |
Member
There was a problem hiding this comment.
the downside is that it will be obfuscated in the release builds, so it will come as obfuscated to our telemetry as well. But I guess the major use-case is still debugging the issue with the debug build.
Contributor
Author
There was a problem hiding this comment.
It will only be obfuscated if it's a user or 3rd party lib exception. All the Java and Android framework excpetions will be in cleartext (the support case that sprung this was because of an ArrayIndexOutOfBounds issue)
jonathanmos
approved these changes
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2411 +/- ##
===========================================
+ Coverage 69.79% 69.94% +0.15%
===========================================
Files 765 765
Lines 28369 28426 +57
Branches 4755 4767 +12
===========================================
+ Hits 19800 19881 +81
+ Misses 7257 7240 -17
+ Partials 1312 1305 -7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve the log message when exception happen during Upload. Right now we only print the error message but not the error type which makes it harder to investigate when an unknown error appears