Fix TextFieldSemanticsNodeMapper flaky test#2410
Merged
Merged
Conversation
ambushwork
marked this pull request as ready for review
November 21, 2024 13:52
0xnm
approved these changes
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2410 +/- ##
===========================================
+ Coverage 69.86% 69.89% +0.03%
===========================================
Files 766 766
Lines 28483 28483
Branches 4778 4778
===========================================
+ Hits 19898 19907 +9
+ Misses 7264 7257 -7
+ Partials 1321 1319 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix TextFieldSemanticsNodeMapper flaky test, it's possible that the random font family in
fakeTextLayoutInfois not GenericFontFamily, so this PR covers the corner case.Review checklist (to be filled by reviewers)