Skip to content

RUM-7091: Add TextField semantics mapper for Session Replay Compose#2406

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/text-field-mapper
Nov 21, 2024
Merged

RUM-7091: Add TextField semantics mapper for Session Replay Compose#2406
ambushwork merged 1 commit into
developfrom
yl/compose/text-field-mapper

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 21, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Add TextField semantics mapper for Session Replay Compose, with this PR, following compose components can be supported:

  • TextField
  • OutlineTextField

Known issue of this mapper:

  • TextField hint text color might not be correct,
  • OutlineTextField can have the correct outline

Motivation

RUM-7091

Demo

Sample App . Session Replay
Screenshot_20241121_095512 ezgif-7-7d88bddb00

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (6cde580) to head (cf4ce23).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
.../mappers/semantics/TextFieldSemanticsNodeMapper.kt 85.42% 1 Missing and 6 partials ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 5 Missing ⚠️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 50.00% 1 Missing and 2 partials ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2406      +/-   ##
===========================================
+ Coverage    69.84%   69.88%   +0.05%     
===========================================
  Files          765      766       +1     
  Lines        28370    28429      +59     
  Branches      4757     4768      +11     
===========================================
+ Hits         19813    19867      +54     
- Misses        7245     7248       +3     
- Partials      1312     1314       +2
Files with missing lines Coverage Δ
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 82.00% <50.00%> (-2.44%) ⬇️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 1.00% <0.00%> (-0.05%) ⬇️
.../mappers/semantics/TextFieldSemanticsNodeMapper.kt 85.42% <85.42%> (ø)

... and 30 files with indirect coverage changes

---- 🚨 Try these New Features:

@ambushwork
ambushwork marked this pull request as ready for review November 21, 2024 09:40
@ambushwork
ambushwork requested review from a team as code owners November 21, 2024 09:40
0xnm
0xnm approved these changes Nov 21, 2024
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions, but overall lgtm

Comment thread .../datadog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapper.kt Outdated
Comment thread .../datadog/android/sessionreplay/compose/internal/mappers/semantics/RootSemanticsNodeMapper.kt Outdated
Comment thread ...dog/android/sessionreplay/compose/internal/mappers/semantics/TextFieldSemanticsNodeMapper.kt
Comment thread ...android/sessionreplay/compose/internal/mappers/semantics/TextFieldSemanticsNodeMapperTest.kt Outdated
@ambushwork
ambushwork force-pushed the yl/compose/text-field-mapper branch from 26d33e0 to cf4ce23 Compare November 21, 2024 10:09
@ambushwork
ambushwork merged commit 47ccfcf into develop Nov 21, 2024
@ambushwork
ambushwork deleted the yl/compose/text-field-mapper branch November 21, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambushwork @codecov-commenter @0xnm