RUM-7337: Adjust Webview Replay storage configuration limits#2400
Merged
jonathanmos merged 1 commit intoNov 20, 2024
Conversation
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/rum-7337/adjust-limits-for-webviews
branch
from
November 19, 2024 13:13
ef6b025 to
aa5f51e
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-7337/adjust-limits-for-webviews
branch
from
November 19, 2024 13:31
aa5f51e to
c5ef356
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2400 +/- ##
===========================================
- Coverage 70.01% 69.83% -0.17%
===========================================
Files 763 763
Lines 28374 28367 -7
Branches 4763 4763
===========================================
- Hits 19864 19810 -54
- Misses 7222 7243 +21
- Partials 1288 1314 +26
|
jonathanmos
marked this pull request as ready for review
November 19, 2024 15:07
0xnm
approved these changes
Nov 19, 2024
|
|
||
| /** | ||
| * Storage configuration with the following parameters: | ||
| * max item size = 10 MB, |
Member
There was a problem hiding this comment.
I'm curious what can generate item with 10 MB size
xgouchet
approved these changes
Nov 20, 2024
jonathanmos
deleted the
jmoskovich/rum-7337/adjust-limits-for-webviews
branch
November 20, 2024 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WebviewReplayFeaturewas using the default storage configuration. As a result, events sent by the browser sdk that were larger than 512kb were being rejected rather than written to batch files. This pr adjusts the size limits to align with session replay - 10mb per item and 10mb per batch.I also added unit tests for
WebviewReplayFeatureas there didn't seem to be any.Motivation
Support ticket where the customer couldn't see their webviews.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)