RUM-7302: Align log levels for sr already enabled#2399
Merged
jonathanmos merged 1 commit intoNov 18, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2399 +/- ##
===========================================
- Coverage 69.82% 69.75% -0.07%
===========================================
Files 763 763
Lines 28360 28363 +3
Branches 4763 4761 -2
===========================================
- Hits 19801 19782 -19
- Misses 7246 7258 +12
- Partials 1313 1323 +10
|
jonathanmos
marked this pull request as ready for review
November 18, 2024 12:35
ambushwork
approved these changes
Nov 18, 2024
0xnm
approved these changes
Nov 18, 2024
jonathanmos
deleted the
jmoskovich/rum-7302/align-levels-sr-already-enabled
branch
November 18, 2024 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Aligns the log levels with iOS for the error we output when a user tries to enable session replay twice (either on the same core or on different cores) - "Session Replay is already enabled"
Motivation
On iOS they output an error to the user and debug to the telemetry.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)