Skip to content

RUM-7291: Integrate benchmark profiler in compose mapper#2397

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/add-compose-mapper-profiler
Nov 15, 2024
Merged

RUM-7291: Integrate benchmark profiler in compose mapper#2397
ambushwork merged 1 commit into
developfrom
yl/compose/add-compose-mapper-profiler

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Integrate benchmark profiler to measure the span of Compose Session Replay

Motivation

RUM-7291

Demo

Compose part start from RootNode span, each component span is name with its mapper:

image

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners November 15, 2024 16:12
@codecov-commenter

codecov-commenter commented Nov 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.82%. Comparing base (c9b82d9) to head (369c467).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 84.62% 3 Missing and 1 partial ⚠️
...ssionreplay/compose/internal/utils/BenchmarkExt.kt 66.67% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2397   +/-   ##
========================================
  Coverage    69.81%   69.82%           
========================================
  Files          762      763    +1     
  Lines        28348    28359   +11     
  Branches      4763     4761    -2     
========================================
+ Hits         19791    19800    +9     
- Misses        7242     7246    +4     
+ Partials      1315     1313    -2     
Files with missing lines Coverage Δ
...ssionreplay/compose/internal/utils/BenchmarkExt.kt 66.67% <66.67%> (ø)
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 84.44% <84.62%> (+2.39%) ⬆️

... and 31 files with indirect coverage changes

@ambushwork
ambushwork merged commit ff6002f into develop Nov 15, 2024
@ambushwork
ambushwork deleted the yl/compose/add-compose-mapper-profiler branch November 15, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants