RUM-7215: Add AndroidComposeViewMapper to support popup#2395
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2395 +/- ##
===========================================
- Coverage 69.79% 69.78% -0.01%
===========================================
Files 760 762 +2
Lines 28310 28341 +31
Branches 4761 4763 +2
===========================================
+ Hits 19757 19777 +20
- Misses 7240 7243 +3
- Partials 1313 1321 +8
|
ambushwork
marked this pull request as ready for review
November 15, 2024 13:43
0xnm
reviewed
Nov 15, 2024
ambushwork
force-pushed
the
yl/compose/add-android-compose-view-mapper
branch
from
November 15, 2024 15:11
ace54a7 to
dd7ea78
Compare
0xnm
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In Jetpack compose, if the composable content is added by
setContent{ }in the activity, then the wrapper view isComposeView, but for the pop up like bottom sheet dialog or Drop down menu, they useAndroidComposeViewas the wrapper in a separatedDecorView.So we need to support
AndroidComposeViewmapping otherwise the Session Replay can not resolve any content in the popup decor view.In this PR, a small refactor is done in order to share the common logic between
ComposeViewMapperandAndroidComposeViewMapper, here is the structure change:Motivation
RUM-7215
Replay Demo
Known issue in demo:
Drop down menu doesn't have the correct position in replay
https://mobile-integration.datadoghq.com/rum/replay/sessions/26a23f05-aa91-427e-9f77-4b3457ac4ba2?applicationId=38030dde-f9f9-4e52-9443-b9804a030080&seed=029b6a93-9744-4fa8-84fe-b166b9a163fe&ts=1731675244745
Review checklist (to be filled by reviewers)