Skip to content

RUM-7215: Add Compose SR selector sample screen#2394

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/add-selector-sample
Nov 15, 2024
Merged

RUM-7215: Add Compose SR selector sample screen#2394
ambushwork merged 1 commit into
developfrom
yl/compose/add-selector-sample

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

A new sample screen is added for Compose Session Replay, three components are added:

  • DropDownMenu
  • BottomSheetDialog
  • Slider

Motivation

RUM-7215

Demo

Screenshot_20241115_124717

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners November 15, 2024 11:49
@codecov-commenter

codecov-commenter commented Nov 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (4665fa3) to head (72dd6c9).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2394      +/-   ##
===========================================
+ Coverage    69.79%   69.81%   +0.01%     
===========================================
  Files          760      760              
  Lines        28310    28310              
  Branches      4761     4761              
===========================================
+ Hits         19758    19762       +4     
+ Misses        7241     7239       -2     
+ Partials      1311     1309       -2     

see 24 files with indirect coverage changes

@ambushwork
ambushwork merged commit 60631b4 into develop Nov 15, 2024
@ambushwork
ambushwork deleted the yl/compose/add-selector-sample branch November 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants