Skip to content

RUM-6866 use deterministic sampling by default when tracing#2388

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-6866/use_deterministic_sampling_by_default
Nov 14, 2024
Merged

RUM-6866 use deterministic sampling by default when tracing#2388
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-6866/use_deterministic_sampling_by_default

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Use the deterministic sampler for traces in OkHttp integration

@xgouchet
xgouchet force-pushed the xgouchet/RUM-6866/use_deterministic_sampling_by_default branch from 56e5e4c to 22cb585 Compare November 14, 2024 09:25
@codecov-commenter

codecov-commenter commented Nov 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (81d4b54) to head (22cb585).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 0.00% 3 Missing ⚠️
...datadog/android/okhttp/trace/TracingInterceptor.kt 40.00% 3 Missing ⚠️
.../android/okhttp/trace/DeterministicTraceSampler.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2388      +/-   ##
===========================================
- Coverage    70.34%   70.28%   -0.05%     
===========================================
  Files          745      746       +1     
  Lines        27727    27727              
  Branches      4626     4628       +2     
===========================================
- Hits         19502    19487      -15     
- Misses        6948     6963      +15     
  Partials      1277     1277              
Files with missing lines Coverage Δ
.../android/okhttp/trace/DeterministicTraceSampler.kt 60.00% <60.00%> (ø)
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 60.00% <0.00%> (ø)
...datadog/android/okhttp/trace/TracingInterceptor.kt 77.02% <40.00%> (ø)

... and 28 files with indirect coverage changes

@xgouchet
xgouchet marked this pull request as ready for review November 14, 2024 10:25
@xgouchet
xgouchet requested review from a team as code owners November 14, 2024 10:25
@xgouchet
xgouchet merged commit 16ff01f into develop Nov 14, 2024
@xgouchet
xgouchet deleted the xgouchet/RUM-6866/use_deterministic_sampling_by_default branch November 14, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants