RUM-6866 create the DeterministicSampler#2387
Merged
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-6866/knuth_sampling
branch
from
November 13, 2024 14:24
0224918 to
566a896
Compare
xgouchet
marked this pull request as ready for review
November 13, 2024 14:27
xgouchet
force-pushed
the
xgouchet/RUM-6866/knuth_sampling
branch
from
November 13, 2024 14:30
566a896 to
426dbca
Compare
Base automatically changed from
xgouchet/RUM-6866/allow_typed_sampler
to
develop
November 13, 2024 14:53
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2387 +/- ##
===========================================
- Coverage 70.31% 70.30% -0.01%
===========================================
Files 744 745 +1
Lines 27694 27716 +22
Branches 4621 4627 +6
===========================================
+ Hits 19471 19483 +12
+ Misses 6947 6938 -9
- Partials 1276 1295 +19
|
0xnm
approved these changes
Nov 13, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a
DeterministicSamplerimplementation consistent with our backend agent implementations (Unit tests cover the Go and Java implementation)