Skip to content

Remove legacy code using compose sourceInfo#2386

Merged
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/remove-legacy-code
Nov 13, 2024
Merged

Remove legacy code using compose sourceInfo#2386
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/remove-legacy-code

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Remove the legacy code using compose sourceInfo

The removed code is archived in leagcy/feature/sr_compose

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (11c0d06) to head (1818c91).
Report is 2 commits behind head on feature/sr_compose.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2386      +/-   ##
======================================================
- Coverage               69.76%   69.76%   -0.00%     
======================================================
  Files                     774      759      -15     
  Lines                   28790    28289     -501     
  Branches                 4889     4763     -126     
======================================================
- Hits                    20085    19735     -350     
+ Misses                   7351     7233     -118     
+ Partials                 1354     1321      -33     
Files with missing lines Coverage Δ
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <ø> (-28.36%) ⬇️

... and 34 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review November 13, 2024 12:00
@ambushwork
ambushwork requested review from a team as code owners November 13, 2024 12:00

@xgouchet xgouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@ambushwork
ambushwork merged commit 1ff6204 into feature/sr_compose Nov 13, 2024
@ambushwork
ambushwork deleted the yl/compose/remove-legacy-code branch November 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants