Skip to content

RUM-7150: Add multiple extension support#2384

Merged
jonathanmos merged 2 commits into
feature/sr_composefrom
jmoskovich/rum-7150/support-multiple-extensions
Nov 14, 2024
Merged

RUM-7150: Add multiple extension support#2384
jonathanmos merged 2 commits into
feature/sr_composefrom
jmoskovich/rum-7150/support-multiple-extensions

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Nov 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Support for adding multiple extensions to the session replay configuration.
• If the same extension is added twice we print an error message.
• If several extensions map to the same type we use the first occurrence and print an error message.

Motivation

This will probably be a commonly required use-case.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.65%. Comparing base (11c0d06) to head (6e09dbf).
Report is 5 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...datadog/android/sessionreplay/MapperTypeWrapper.kt 80.00% 0 Missing and 1 partial ⚠️
...ndroid/sessionreplay/SessionReplayConfiguration.kt 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2384      +/-   ##
======================================================
- Coverage               69.76%   69.65%   -0.12%     
======================================================
  Files                     774      773       -1     
  Lines                   28790    28806      +16     
  Branches                 4889     4893       +4     
======================================================
- Hits                    20085    20062      -23     
- Misses                   7351     7371      +20     
- Partials                 1354     1373      +19
Files with missing lines Coverage Δ
...d/sessionreplay/compose/ComposeExtensionSupport.kt 87.50% <100.00%> (+1.79%) ⬆️
...sessionreplay/material/MaterialExtensionSupport.kt 97.30% <100.00%> (+0.15%) ⬆️
...datadog/android/sessionreplay/MapperTypeWrapper.kt 90.00% <80.00%> (-10.00%) ⬇️
...ndroid/sessionreplay/SessionReplayConfiguration.kt 96.15% <95.45%> (-0.86%) ⬇️

... and 28 files with indirect coverage changes

ambushwork
ambushwork reviewed Nov 12, 2024
View reviewed changes
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...y/src/test/kotlin/com/datadog/android/sessionreplay/SessionReplayConfigurationBuilderTest.kt Outdated
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch 3 times, most recently from e4ba5ba to 9a9b3db Compare November 13, 2024 08:44
ambushwork
ambushwork previously approved these changes Nov 13, 2024
View reviewed changes
@jonathanmos
jonathanmos marked this pull request as ready for review November 13, 2024 10:38
@jonathanmos
jonathanmos requested review from a team as code owners November 13, 2024 10:38
@jonathanmos
jonathanmos marked this pull request as draft November 13, 2024 10:38
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch from 9a9b3db to 80ff449 Compare November 13, 2024 11:13
@jonathanmos
jonathanmos changed the base branch from develop to feature/sr_compose November 13, 2024 11:13
@jonathanmos
jonathanmos dismissed ambushwork’s stale review November 13, 2024 11:13

The base branch was changed.

@jonathanmos
jonathanmos marked this pull request as ready for review November 13, 2024 12:13
ambushwork
ambushwork previously approved these changes Nov 13, 2024
View reviewed changes
@ambushwork

ambushwork commented Nov 13, 2024

Copy link
Copy Markdown
Member

Well done !

0xnm
0xnm reviewed Nov 13, 2024
View reviewed changes
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch from 80ff449 to 69448ce Compare November 13, 2024 14:19
@jonathanmos
jonathanmos requested a review from 0xnm November 13, 2024 14:20
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch 2 times, most recently from 99df836 to 27e8175 Compare November 13, 2024 14:31
@jonathanmos
jonathanmos requested a review from 0xnm November 13, 2024 14:39
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch from 27e8175 to 2cbb9c1 Compare November 13, 2024 14:49
0xnm
0xnm previously approved these changes Nov 13, 2024
View reviewed changes
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...y/src/test/kotlin/com/datadog/android/sessionreplay/SessionReplayConfigurationBuilderTest.kt Outdated
ambushwork
ambushwork previously approved these changes Nov 13, 2024
View reviewed changes
0xnm
0xnm reviewed Nov 13, 2024
View reviewed changes
Comment thread features/dd-sdk-android-session-replay/api/dd-sdk-android-session-replay.api Outdated
0xnm
0xnm previously approved these changes Nov 13, 2024
View reviewed changes
Comment thread features/dd-sdk-android-session-replay/api/dd-sdk-android-session-replay.api
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch from cc420bf to 2caecac Compare November 14, 2024 08:52
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7150/support-multiple-extensions branch from 2caecac to 6e09dbf Compare November 14, 2024 09:09
@jonathanmos
jonathanmos merged commit 4d7cd9b into feature/sr_compose Nov 14, 2024
@jonathanmos
jonathanmos deleted the jmoskovich/rum-7150/support-multiple-extensions branch November 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @ambushwork @0xnm