RUM-6198: Add RadioButton Semantics Node Mapper#2381
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2381 +/- ##
======================================================
- Coverage 69.61% 69.54% -0.06%
======================================================
Files 772 773 +1
Lines 28719 28758 +39
Branches 4885 4887 +2
======================================================
+ Hits 19990 19999 +9
- Misses 7365 7384 +19
- Partials 1364 1375 +11
|
ambushwork
force-pushed
the
yl/compose/add-switch-sample
branch
3 times, most recently
from
November 7, 2024 14:49
64699b5 to
b671473
Compare
ambushwork
marked this pull request as ready for review
November 7, 2024 15:28
0xnm
previously approved these changes
Nov 7, 2024
ambushwork
force-pushed
the
yl/compose/add-switch-sample
branch
from
November 7, 2024 15:52
b671473 to
d5be643
Compare
0xnm
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add RadioButton Semantics Node Mapper.
Since we are not able to retrieve the image of button, we use shape to simulate the radio button.
And color of the button needs to be retrieved by reflection, here is a follow up tickets: RUM-7116
Motivation
RUM-6198
Demo
Review checklist (to be filled by reviewers)