RUM-6200: Add Tab semantics mapper#2378
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2378 +/- ##
======================================================
+ Coverage 69.61% 69.69% +0.08%
======================================================
Files 771 772 +1
Lines 28690 28719 +29
Branches 4877 4885 +8
======================================================
+ Hits 19971 20014 +43
+ Misses 7361 7346 -15
- Partials 1358 1359 +1
|
ambushwork
marked this pull request as ready for review
November 6, 2024 12:38
0xnm
previously approved these changes
Nov 6, 2024
ambushwork
force-pushed
the
yl/compose/add-tab-mapper
branch
from
November 6, 2024 12:56
057ce4f to
9b612d9
Compare
Member
Author
|
unit test added |
0xnm
previously approved these changes
Nov 6, 2024
ambushwork
force-pushed
the
yl/compose/add-tab-mapper
branch
from
November 6, 2024 16:24
9b612d9 to
86d9761
Compare
0xnm
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Tab semantics mapper to resolve tab component to wireframe for Session Replay
Known issue:
We are not able to have the correct color for the image in the tab bar, because we retrieve directly Bitmap, not a tintable drawable.
Motivation
RUM-6200
Demo
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)