Skip to content

Add experimental annotation for Session Replay and Add it for Compose#2377

Merged
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/add-experimental-annotation
Nov 6, 2024
Merged

Add experimental annotation for Session Replay and Add it for Compose#2377
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/add-experimental-annotation

Conversation

@ambushwork

@ambushwork ambushwork commented Nov 6, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Add experimental annotation for Session Replay and Add it for Compose extension so that clients will be aware of the functionality is not stable.

Motivation

Preparation for merging the feature/sr_compose into develop

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/compose/add-experimental-annotation branch from 145a8b7 to 2f03af4 Compare November 6, 2024 10:02
@ambushwork
ambushwork force-pushed the yl/compose/add-experimental-annotation branch from 2f03af4 to e85c792 Compare November 6, 2024 10:42
@codecov-commenter

codecov-commenter commented Nov 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (cd1b01e) to head (e85c792).
Report is 2 commits behind head on feature/sr_compose.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2377      +/-   ##
======================================================
- Coverage               69.61%   69.57%   -0.04%     
======================================================
  Files                     771      771              
  Lines                   28690    28685       -5     
  Branches                 4877     4878       +1     
======================================================
- Hits                    19971    19957      -14     
  Misses                   7361     7361              
- Partials                 1358     1367       +9     
Files with missing lines Coverage Δ
...d/sessionreplay/compose/ComposeExtensionSupport.kt 85.71% <100.00%> (ø)

... and 33 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review November 6, 2024 12:21
@ambushwork
ambushwork requested review from a team as code owners November 6, 2024 12:21
@ambushwork
ambushwork merged commit 132ec14 into feature/sr_compose Nov 6, 2024
@ambushwork
ambushwork deleted the yl/compose/add-experimental-annotation branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants