RUM-3460: Fix padding and resizing issue for image view mapper#2372
Merged
Conversation
ambushwork
marked this pull request as ready for review
November 4, 2024 17:04
0xnm
approved these changes
Nov 5, 2024
jonathanmos
approved these changes
Nov 5, 2024
xgouchet
approved these changes
Nov 5, 2024
ambushwork
force-pushed
the
yl/sr-mnt/fix-image-view-padding
branch
from
November 5, 2024 07:41
6333f4c to
95ab882
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2372 +/- ##
===========================================
+ Coverage 70.30% 70.37% +0.07%
===========================================
Files 744 744
Lines 27721 27726 +5
Branches 4630 4630
===========================================
+ Hits 19488 19512 +24
+ Misses 6947 6936 -11
+ Partials 1286 1278 -8
|
ambushwork
force-pushed
the
yl/sr-mnt/fix-image-view-padding
branch
from
November 5, 2024 12:12
95ab882 to
fe466c9
Compare
xgouchet
approved these changes
Nov 5, 2024
xgouchet
left a comment
xgouchet
left a comment
Contributor
There was a problem hiding this comment.
Note
Shouldn't we have some unit tests around those functions ?
ambushwork
force-pushed
the
yl/sr-mnt/fix-image-view-padding
branch
from
November 5, 2024 17:11
fe466c9 to
39c3e59
Compare
Member
Author
@xgouchet there are unit tests around these, I just updated with the padding case to cover it better, and instrumented test payloads are regenerated for them. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In app development, clients usually use paddings to resize the content drawable in a given size image view, prior to this PR we didn't taken into account these paddings to resize our image wireframe, which leads some images/icons bigger than real.
So the updates in this PR:
resolveParentRectAbsPositionfunctionGradientDrawabledidn't take into account the width&height after resizing.Motivation
RUM-3460
Demo
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)