Fix resolveResourceId not correctly calling job finished when drawable cloning failed#2367
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.15.0 #2367 +/- ##
==================================================
- Coverage 70.51% 70.34% -0.17%
==================================================
Files 741 741
Lines 27646 27648 +2
Branches 4628 4628
==================================================
- Hits 19493 19447 -46
- Misses 6893 6914 +21
- Partials 1260 1287 +27
|
ambushwork
force-pushed
the
yl/sr-mnt/fix-resource-resolver
branch
from
November 3, 2024 20:50
579c4e8 to
525cd65
Compare
jonathanmos
approved these changes
Nov 4, 2024
xgouchet
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Snapshot item is never processed due to the fix in this PR,
this is because we call
job.startedcallback but never calljob.finished, so the snapshot is always in pending state.Review checklist (to be filled by reviewers)