Skip to content

RUM-6897: Fix scrolling issue#2351

Merged
jonathanmos merged 1 commit into
feature/fix-frozen-scrollingfrom
jmoskovich/new-fix-frozen-images
Oct 28, 2024
Merged

RUM-6897: Fix scrolling issue#2351
jonathanmos merged 1 commit into
feature/fix-frozen-scrollingfrom
jmoskovich/new-fix-frozen-images

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Oct 28, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Part of fixing the frozen scrolling when MASK_NONE is selected for image privacy. We were using the copy of the drawable as the key in the resource cache and this resulted in cache misses. This pr changes the behavior to use the original drawable to generate the key.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanmos
jonathanmos marked this pull request as ready for review October 28, 2024 11:54
@jonathanmos
jonathanmos requested review from a team as code owners October 28, 2024 11:54
@jonathanmos
jonathanmos merged commit f024089 into feature/fix-frozen-scrolling Oct 28, 2024
@jonathanmos
jonathanmos deleted the jmoskovich/new-fix-frozen-images branch October 28, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants