RUM-5873: Reactivate Session Replay instrumented test for API 21#2342
Conversation
dc45cd5 to
d5adb23
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-integration-test #2342 +/- ##
===============================================================
- Coverage 70.35% 70.34% -0.01%
===============================================================
Files 739 739
Lines 27562 27564 +2
Branches 4617 4619 +2
===============================================================
- Hits 19391 19389 -2
- Misses 6878 6890 +12
+ Partials 1293 1285 -8
|
0xnm
left a comment
0xnm
left a comment
There was a problem hiding this comment.
lgtm, but I believe we will still have a wrong stacktrace in case if test fails on API 21, because some classes used by AssertJ don't exist there?
|
@0xnm I am not sure what do you mean, can you elaborate? |
|
I mean AssertJ is using some Java 8+ classes (ex. |
|
@0xnm I see, do you have a quick workaround on this? otherwise we will create a ticket for it and let it be in this PR. |
|
The only quick workaround is desugaring, but I don't think we want to enable it. So let's keep it like that. |
3 participants
What does this PR do?
Reactive Session Replay instrumented test for API 21,
Fix a drawable resolving issue due to the different behavior on lower API.
Motivation
RUM-5873
Review checklist (to be filled by reviewers)