Fix the decompression in SR instrumented tests for API 21#2341
Merged
mariusc83 merged 1 commit intoOct 24, 2024
Merged
Conversation
0xnm
approved these changes
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-integration-test #2341 +/- ##
===============================================================
+ Coverage 70.35% 70.37% +0.01%
===============================================================
Files 739 739
Lines 27562 27562
Branches 4617 4617
===============================================================
+ Hits 19391 19395 +4
- Misses 6878 6880 +2
+ Partials 1293 1287 -6 |
ambushwork
approved these changes
Oct 23, 2024
jonathanmos
approved these changes
Oct 24, 2024
mariusc83
deleted the
mconstantin/fix-decompression-in-sr-end-to-end-tests
branch
October 24, 2024 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In our SR instrumented tests we need to decompress the segments intercepted through the
MockServerin order to be able to assess them with the expected payloads.The segments are previously compressed with a
deflatealg and we are using anInflaterinstance in the SR tests to deflate them.The
Inflaterclass logic is buggy in the Android API 21 JVM. For some reason theinflater.finishedmethod always returnsfalsehaving our decompression logic running in an endless loop.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)