Skip to content

Fix Image reflection issue and proguard rules#2337

Merged
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/fix-image-reflection-issue
Oct 22, 2024
Merged

Fix Image reflection issue and proguard rules#2337
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/fix-image-reflection-issue

Conversation

@ambushwork

@ambushwork ambushwork commented Oct 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Changes some proguard rules in order to make the code work in release build.
  • Changes some reflection logic for image mapper in order to make it work in higher version of Coil
  • Change the bitmap copy config in order to make it work for Bitmap ALPHA config.
  • Update the sample app image showcase screen.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Oct 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (71c250b) to head (bcc5f79).
Report is 2 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2337      +/-   ##
======================================================
- Coverage               69.45%   69.43%   -0.02%     
======================================================
  Files                     753      753              
  Lines                   27945    27950       +5     
  Branches                 4779     4783       +4     
======================================================
- Hits                    19409    19406       -3     
- Misses                   7175     7195      +20     
+ Partials                 1361     1349      -12
Files with missing lines Coverage Δ
...rnal/mappers/semantics/ImageSemanticsNodeMapper.kt 1.79% <0.00%> (-0.18%) ⬇️

... and 23 files with indirect coverage changes

@ambushwork
ambushwork marked this pull request as ready for review October 22, 2024 08:19
@ambushwork
ambushwork requested review from a team as code owners October 22, 2024 08:19
0xnm
0xnm approved these changes Oct 22, 2024
View reviewed changes
Comment thread features/dd-sdk-android-session-replay-compose/consumer-rules.pro
Comment thread ...datadog/android/sessionreplay/compose/internal/mappers/semantics/ImageSemanticsNodeMapper.kt
@ambushwork
ambushwork merged commit 6f3c5f3 into feature/sr_compose Oct 22, 2024
@ambushwork
ambushwork deleted the yl/compose/fix-image-reflection-issue branch October 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @xgouchet @0xnm