RUM-6293: Remove Batch metrics inner sampler to increase sample rate#2328
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2328 +/- ##
===========================================
- Coverage 70.41% 70.39% -0.02%
===========================================
Files 739 739
Lines 27536 27536
Branches 4614 4614
===========================================
- Hits 19388 19383 -5
+ Misses 6866 6863 -3
- Partials 1282 1290 +8
|
ambushwork
marked this pull request as ready for review
October 17, 2024 13:39
0xnm
approved these changes
Oct 17, 2024
mariusc83
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The whole context please check the ticket: RUM-6293
TL,DR;
The sample rate should be decreased by 10 times but wrongly decreased by 1000 times,
Since we have add sample rate option on
logMetricmethod, now it doesn't make sense to have another sampler insideBatchMetricsDispatcher. By removing it, the sample rate is simply controlled by the parameter passed intologMetricand the total sample rate will be increased by (1/0.015f) = 66.6 times.Motivation
RUM-6293
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)