RUM-6375: Force single core for session replay#2324
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-6375/force-single-core
branch
from
October 16, 2024 14:29
b70a0a4 to
4fbbd96
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2324 +/- ##
===========================================
- Coverage 70.42% 70.37% -0.05%
===========================================
Files 740 740
Lines 27593 27604 +11
Branches 4622 4624 +2
===========================================
- Hits 19430 19425 -5
- Misses 6878 6888 +10
- Partials 1285 1291 +6
|
jonathanmos
force-pushed
the
jmoskovich/rum-6375/force-single-core
branch
2 times, most recently
from
October 20, 2024 07:41
361cf42 to
a7e2344
Compare
jonathanmos
marked this pull request as ready for review
October 20, 2024 10:12
xgouchet
suggested changes
Oct 21, 2024
xgouchet
approved these changes
Oct 22, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6375/force-single-core
branch
from
October 22, 2024 13:04
e5194c4 to
154134f
Compare
ambushwork
approved these changes
Oct 23, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6375/force-single-core
branch
from
October 23, 2024 07:53
154134f to
0cf1490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow session replay to run on only one core at a time. Attempting to start sr on more cores will send telemetry.
Motivation
It probably doesn't make sense for session replay to run on multiple cores.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)