RUM-6385: Default sample rate for session replay#2323
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-6385/default-sr-sample-rate
branch
from
October 15, 2024 09:28
f9716c4 to
3cba5ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2323 +/- ##
===========================================
- Coverage 70.37% 70.36% -0.01%
===========================================
Files 738 738
Lines 27529 27530 +1
Branches 4616 4616
===========================================
- Hits 19372 19371 -1
- Misses 6864 6865 +1
- Partials 1293 1294 +1
|
jonathanmos
marked this pull request as ready for review
October 15, 2024 10:26
ambushwork
reviewed
Oct 15, 2024
xgouchet
approved these changes
Oct 16, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6385/default-sr-sample-rate
branch
from
October 16, 2024 07:22
3cba5ef to
2837584
Compare
ambushwork
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a default sample rate of 100% for Session Replay (sample rate is now optional when creating the configuration).
Motivation
Align with the other features.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)