RUM-3469: Resolve PorterDuffColorFilter case in drawable to color mapper#2319
Merged
ambushwork merged 1 commit intoOct 11, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-integration-test #2319 +/- ##
===============================================================
- Coverage 70.30% 70.23% -0.07%
===============================================================
Files 736 736
Lines 27465 27490 +25
Branches 4607 4608 +1
===============================================================
- Hits 19308 19307 -1
- Misses 6876 6891 +15
- Partials 1281 1292 +11
|
ambushwork
marked this pull request as ready for review
October 11, 2024 08:42
xgouchet
approved these changes
Oct 11, 2024
0xnm
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In lower version of Android, the color information is stored in
paint.colorFilterinstead ofpaint,So we need to retrieve it from
colorFilter.mColorattribute to have the correct color for drawable.Motivation
RUM-3469
Review checklist (to be filled by reviewers)