RUM-5873: Update Session Replay integration test payloads#2318
Merged
ambushwork merged 1 commit intoOct 23, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-integration-test #2318 +/- ##
===============================================================
+ Coverage 70.35% 70.38% +0.03%
===============================================================
Files 739 739
Lines 27562 27562
Branches 4617 4617
===============================================================
+ Hits 19391 19399 +8
+ Misses 6878 6876 -2
+ Partials 1293 1287 -6 |
ambushwork
force-pushed
the
yl/it/generate-json-payload
branch
3 times, most recently
from
October 21, 2024 15:50
06fdf24 to
259d644
Compare
ambushwork
force-pushed
the
yl/it/generate-json-payload
branch
2 times, most recently
from
October 23, 2024 07:47
0c90c78 to
4cd5f76
Compare
ambushwork
marked this pull request as ready for review
October 23, 2024 07:53
0xnm
previously approved these changes
Oct 23, 2024
jonathanmos
previously approved these changes
Oct 23, 2024
ambushwork
force-pushed
the
yl/it/generate-json-payload
branch
from
October 23, 2024 09:17
4cd5f76 to
63fb98d
Compare
0xnm
reviewed
Oct 23, 2024
ambushwork
force-pushed
the
yl/it/generate-json-payload
branch
from
October 23, 2024 11:46
63fb98d to
7acd741
Compare
0xnm
approved these changes
Oct 23, 2024
xgouchet
approved these changes
Oct 23, 2024
jonathanmos
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Session replay integration test payloads by using the same config of emulator as gitlab ci,
and remove all the
@ignorefor SR tests.Some other changes:
@Ignoreis removed but@SdkSuppressis added to ignore the SR instrumented tests on legacy-min-api task, because there is an underlying issue make test block forever.edgeToEdgeis enabled by default, which makes top content covered by the toolbar, it can lead different wireframes.Motivation
RUM-5873
Review checklist (to be filled by reviewers)