Skip to content

Improve RUM integration tests#2317

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/reliability/sfit_rum_coverage
Oct 15, 2024
Merged

Improve RUM integration tests#2317
xgouchet merged 1 commit into
developfrom
xgouchet/reliability/sfit_rum_coverage

Conversation

@xgouchet

@xgouchet xgouchet commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Add missing tests to get a better coverage of the RUM apis in the Integration Tests

Base automatically changed from xgouchet/reliability/it_api_coverage to develop October 9, 2024 09:22
@xgouchet
xgouchet force-pushed the xgouchet/reliability/sfit_rum_coverage branch from d87e61f to fb18021 Compare October 10, 2024 11:08
@codecov-commenter

codecov-commenter commented Oct 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (4b83197) to head (4a380bb).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 88.24% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2317      +/-   ##
===========================================
+ Coverage    70.29%   70.31%   +0.01%     
===========================================
  Files          736      737       +1     
  Lines        27469    27457      -12     
  Branches      4607     4605       -2     
===========================================
- Hits         19309    19304       -5     
- Misses        6868     6875       +7     
+ Partials      1292     1278      -14     
Files with missing lines Coverage Δ
.../rum/internal/monitor/AdvancedNetworkRumMonitor.kt 0.00% <ø> (ø)
.../rum/tracking/ActivityLifecycleTrackingStrategy.kt 88.46% <ø> (-1.54%) ⬇️
...tlin/com/datadog/android/rum/tracking/BundleExt.kt 100.00% <100.00%> (ø)
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 88.89% <100.00%> (ø)
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.36% <100.00%> (ø)
...roid/compose/internal/ComposeNavigationObserver.kt 90.91% <100.00%> (+1.62%) ⬆️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 87.76% <88.24%> (-2.87%) ⬇️

... and 30 files with indirect coverage changes

@xgouchet
xgouchet force-pushed the xgouchet/reliability/sfit_rum_coverage branch from fb18021 to bcb50a1 Compare October 11, 2024 09:18
@xgouchet
xgouchet marked this pull request as ready for review October 14, 2024 07:11
@xgouchet
xgouchet requested review from a team as code owners October 14, 2024 07:11
@xgouchet
xgouchet force-pushed the xgouchet/reliability/sfit_rum_coverage branch from bcb50a1 to 715db4b Compare October 14, 2024 07:14
@xgouchet
xgouchet requested a review from mariusc83 October 14, 2024 12:33
@xgouchet
xgouchet force-pushed the xgouchet/reliability/sfit_rum_coverage branch from 715db4b to c3ffedd Compare October 14, 2024 13:24
@xgouchet
xgouchet force-pushed the xgouchet/reliability/sfit_rum_coverage branch from c3ffedd to 4a380bb Compare October 14, 2024 15:16
@xgouchet
xgouchet merged commit c3e7cb7 into develop Oct 15, 2024
@xgouchet
xgouchet deleted the xgouchet/reliability/sfit_rum_coverage branch October 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants