Fix: use Java 11 bytecode for public modules#2315
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2315 +/- ##
===========================================
+ Coverage 70.32% 70.36% +0.04%
===========================================
Files 736 736
Lines 27465 27466 +1
Branches 4607 4607
===========================================
+ Hits 19313 19325 +12
+ Misses 6863 6856 -7
+ Partials 1289 1285 -4 |
0xnm
marked this pull request as ready for review
October 8, 2024 14:32
mariusc83
approved these changes
Oct 8, 2024
ambushwork
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that some public modules were inconsistent in terms of the Java bytecode version produced, they had Java 17. Fixing it to align with other modules, to use Java 11.
Review checklist (to be filled by reviewers)