Remove unnecessary legacy privacy line from the sampleApplication#2314
Merged
Conversation
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/remove-legacy-privacy
branch
from
October 8, 2024 10:33
6290b12 to
0e25e12
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2314 +/- ##
===========================================
+ Coverage 70.32% 70.33% +0.01%
===========================================
Files 736 736
Lines 27465 27466 +1
Branches 4607 4607
===========================================
+ Hits 19314 19317 +3
- Misses 6861 6863 +2
+ Partials 1290 1286 -4 |
jonathanmos
marked this pull request as ready for review
October 8, 2024 11:33
0xnm
approved these changes
Oct 8, 2024
xgouchet
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed a problem in the sampleApplication - we had a line there setting the legacy privacy. This is overwriting the value from the useLegacyConfiguration method.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)