RUM-6219: Add Image and TextAndInput privacy overrides#2312
Merged
jonathanmos merged 1 commit intoOct 14, 2024
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-6219/text-image-privacy-overrides
branch
from
October 8, 2024 08:30
28f37ed to
83cf711
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2312 +/- ##
===========================================
+ Coverage 70.33% 70.42% +0.09%
===========================================
Files 738 738
Lines 27493 27529 +36
Branches 4610 4616 +6
===========================================
+ Hits 19337 19386 +49
+ Misses 6873 6862 -11
+ Partials 1283 1281 -2
|
jonathanmos
marked this pull request as ready for review
October 8, 2024 10:09
xgouchet
approved these changes
Oct 8, 2024
ambushwork
reviewed
Oct 8, 2024
mariusc83
approved these changes
Oct 8, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6219/text-image-privacy-overrides
branch
from
October 9, 2024 18:35
83cf711 to
78d2981
Compare
ambushwork
approved these changes
Oct 10, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-6219/text-image-privacy-overrides
branch
2 times, most recently
from
October 14, 2024 07:07
6475493 to
8399c2a
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-6218/implement-hidden-privacy-override
branch
from
October 14, 2024 07:57
715c7b1 to
f16a5d4
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-6219/text-image-privacy-overrides
branch
from
October 14, 2024 08:01
8399c2a to
9124b62
Compare
Base automatically changed from
jmoskovich/rum-6218/implement-hidden-privacy-override
to
develop
October 14, 2024 08:48
jonathanmos
deleted the
jmoskovich/rum-6219/text-image-privacy-overrides
branch
October 14, 2024 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds privacy overrides for images and textAndInput.
Api example:
view.setSessionReplayImagePrivacy(privacy: ImagePrivacy?)view.setSessionReplayTextAndInputPrivacy(privacy: TextAndInputPrivacy?)These privacy overrides work on nearest parent - so if you override the privacy on a viewgroup, it should be propagated to the children unless they have their own override.
Motivation
Part of the fine grained masking effort.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)